medusa icon indicating copy to clipboard operation
medusa copied to clipboard

Pass cart_id so that prices can be calculated correctly.

Open Arsenalist opened this issue 1 year ago • 4 comments

Fixes https://github.com/medusajs/medusa/issues/7362

Arsenalist avatar May 30 '24 15:05 Arsenalist

⚠️ No Changeset found

Latest commit: 1b128afca780077e0a80b6e57a91f893a3c6c257

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 30 '24 15:05 changeset-bot[bot]

@Arsenalist is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 30 '24 15:05 vercel[bot]

@adrien2p - possible to approve this? It's a small change which fixes a clear bug which is easily reproducible.

Arsenalist avatar Jun 20 '24 17:06 Arsenalist

@olivermrbl wdyt? it sounds good to me

adrien2p avatar Jun 21 '24 10:06 adrien2p

@olivermrbl wdyt? it sounds good to me

Will this be ported to 2.0 as well or is separate PR needed?

Arsenalist avatar Jul 08 '24 21:07 Arsenalist

Is this ok to be merged? Its a one line change.

Arsenalist avatar Jul 24 '24 00:07 Arsenalist

@Arsenalist, should be good. Will merge and include in the next release later this week :)

olivermrbl avatar Jul 24 '24 07:07 olivermrbl

@olivermrbl Thank you for merging. Can you please answer this question:

Will this be ported to 2.0 as well or is separate PR needed?

Arsenalist avatar Jul 29 '24 18:07 Arsenalist