medusa icon indicating copy to clipboard operation
medusa copied to clipboard

Feat(fulfillment): service provider registration

Open adrien2p opened this issue 1 year ago • 2 comments

adrien2p avatar Feb 27 '24 12:02 adrien2p

🦋 Changeset detected

Latest commit: 33c187f2a4059d3bc8d2b410c39d40844ed45fb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@medusajs/types Patch
@medusajs/utils Patch
medusa-test-utils Patch
@medusajs/promotion Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 27 '24 12:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 10:43am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 5, 2024 10:43am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 10:43am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 10:43am

vercel[bot] avatar Feb 27 '24 12:02 vercel[bot]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 01 '24 08:03 gitguardian[bot]

@olivermrbl in order to not end up with a too big pr I believe a review at this stage would be nice to have already

adrien2p avatar Mar 04 '24 11:03 adrien2p

@olivermrbl only git guardians is being red, should I do something?

adrien2p avatar Mar 04 '24 12:03 adrien2p

From a user's perspective, how would loading plugins look like?

Also, do we want to keep the plugins as a flat list of folders (eg. fulfillment-manual) in the repo, or do we want to prefix/suffix them with something so we distinguish between modules and plugins?

@sradevski loading module providers looks like this

adrien2p avatar Mar 04 '24 15:03 adrien2p

@sradevski loading module providers looks like this

@adrien2p great thanks, good with me. How about the location/placement of these plugins, should we make it a bit more obvious that they are indeed plugins? Or do you think just prefixing them with the module they are a plugin for is enough?

sradevski avatar Mar 04 '24 16:03 sradevski

@sradevski loading module providers looks like this

@adrien2p great thanks, good with me. How about the location/placement of these plugins, should we make it a bit more obvious that they are indeed plugins? Or do you think just prefixing them with the module they are a plugin for is enough?

I don't have a strong opinion on this for now, I believe there is some cleanup between the plugins, the module provider plugins and the module todo. Also, maybe reorganising the monorepo structure could help as we start having so many thing it become hard to navigate

adrien2p avatar Mar 04 '24 16:03 adrien2p

@olivermrbl should I slap an automerge now?

adrien2p avatar Mar 05 '24 10:03 adrien2p

@adrien2p sure!

olivermrbl avatar Mar 05 '24 11:03 olivermrbl