medusa icon indicating copy to clipboard operation
medusa copied to clipboard

feat(admin-ui, localization, translation): Turkish translation

Open desneck opened this issue 1 year ago • 2 comments

desneck avatar Feb 19 '24 15:02 desneck

⚠️ No Changeset found

Latest commit: ffddc2164323a3d195e642b40f144e97c05f76fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 19 '24 15:02 changeset-bot[bot]

@desneck is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 19 '24 15:02 vercel[bot]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password ffddc2164323a3d195e642b40f144e97c05f76fe .github/workflows/action.yml View secret
- Generic Password ffddc2164323a3d195e642b40f144e97c05f76fe .github/workflows/action.yml View secret
- Generic Password ffddc2164323a3d195e642b40f144e97c05f76fe .github/workflows/action.yml View secret
- Generic Password ffddc2164323a3d195e642b40f144e97c05f76fe .github/workflows/action.yml View secret
- Generic Password ffddc2164323a3d195e642b40f144e97c05f76fe .github/workflows/action.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Mar 01 '24 15:03 gitguardian[bot]

@desneck, we appreciate the contribution. However, our admin system is currently undergoing a redesign that includes improvements to and simplifying of translations and we will therefore not accept this PR.

We expect to go live with the update next month. If you are still interested in contributing then, we would very much appreciate a new PR with changes that follow the new format.

I apologize for the slow response time.

olivermrbl avatar Mar 06 '24 17:03 olivermrbl

@olivermrbl, no problem at all and thank you for the response, of course i would love to contribute on the upcoming releases.

Good luck!

desneck avatar Mar 07 '24 11:03 desneck

@desneck, we appreciate the contribution. However, our admin system is currently undergoing a redesign that includes improvements to and simplifying of translations and we will therefore not accept this PR.

We expect to go live with the update next month. If you are still interested in contributing then, we would very much appreciate a new PR with changes that follow the new format.

I apologize for the slow response time.

Is there any ETA for consolidation? We are planning to add Spanish localization.

SalahAdDin avatar May 31 '24 02:05 SalahAdDin