medusa icon indicating copy to clipboard operation
medusa copied to clipboard

Update portuguese translations

Open joevtap opened this issue 1 year ago • 4 comments

  • What - Portuguese translations update
  • Why - Admin UI translations for portuguese were outdated
  • How - Merged english translations file with current portuguese translations file and made the update over values for the diff keys
  • Testing - Couldn't run the project locally, but I basically just changed values for keys from the translations file, it should be working

joevtap avatar Feb 16 '24 16:02 joevtap

⚠️ No Changeset found

Latest commit: 042d4075985afa2e0aff66e6b6eef1cfebdc4ade

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 16 '24 16:02 changeset-bot[bot]

@joevtap is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 16 '24 16:02 vercel[bot]

Great! Eager for the approval 👍🏽

JoKenPo avatar Feb 16 '24 22:02 JoKenPo

I added a chore commit reformatting the file to use 4 spaces instead of 2 (because the diff view was messy with thousands of changes) and notice some typos in translations tokens, for example:

  • "Calculated" spelled as "Calcualted" both in the token name from translation file and in the source code using said token
  • Same thing with "Occurred" being spelled as "Occured"

Since the scope of this PR is translation only, I kept the typos and "duplication" of keys (quoted because just the spelling is different, the key is tecnically the same).

joevtap avatar Feb 17 '24 02:02 joevtap

@joevtap, we appreciate the contribution. However, our admin system is currently undergoing a redesign that includes improvements to and simplifying of translations and we will therefore not accept this PR.

We expect to go live with the update next month. If you are still interested in contributing then, we would very much appreciate a new PR with changes that follow the new format.

I apologize for the slow response time.

olivermrbl avatar Mar 06 '24 17:03 olivermrbl

@joevtap, we appreciate the contribution. However, our admin system is currently undergoing a redesign that includes improvements to and simplifying of translations and we will therefore not accept this PR.

We expect to go live with the update next month. If you are still interested in contributing then, we would very much appreciate a new PR with changes that follow the new format.

I apologize for the slow response time.

I see. Then, when the time comes, I will be happy to make another PR.

joevtap avatar Mar 06 '24 17:03 joevtap