medusa
medusa copied to clipboard
feat(): sendgrid plugin typescript rewrite
rewrite SendGrid plugin to typescript; bump SendGrid dep and rewrite to new medusa API
adds some functionality also as custom subject to orders
and some docs corrections order_shipped_template
should be order_shipment_created_template
it has breaking changes in the plugin configuration i updated the docs too
⚠️ No Changeset found
Latest commit: b01878a3d9478612c2ee1bb54c9e5c84a0be4c59
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Someone is attempting to deploy a commit to the medusajs Team on Vercel.
A member of the Team first needs to authorize it.
@kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p
@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later
@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later
@adrien2p ok, thanks. I reverted the package version to the original
any news? @kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p
any news?
There is also a major error in docs after the recent push order_shipped_template
should be order_shipment_created_template
I already tested it in my production
@kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p
bump
Sorry for the lack of response, we are currently focused on medusa 2.0 but we will get back to you 👍
Hey @luluhoc , as the architecture of how notifications in v2 changed significantly, We will close this PR. Thanks for the contribution though, I hope at the very least helped you got a better understanding of Medusa, and we'll be looking forward to your contributions again!
@sradevski Hey, I understand that it may not be suitable for v2, although it fixes some problems with the plugin in 1.x so it still could have been merged to 1.x train.
@luluhoc if there is a bug that needs fixing, let's have a PR just for that fix. Converting to TS shouldn't be a requirement to do that, as it makes it much more time-consuming for us to review it, without a long-term benefit.