medusa icon indicating copy to clipboard operation
medusa copied to clipboard

feat(): sendgrid plugin typescript rewrite

Open luluhoc opened this issue 6 months ago • 10 comments

rewrite SendGrid plugin to typescript; bump SendGrid dep and rewrite to new medusa API

adds some functionality also as custom subject to orders

and some docs corrections order_shipped_template should be order_shipment_created_template

it has breaking changes in the plugin configuration i updated the docs too

luluhoc avatar Jan 02 '24 13:01 luluhoc

⚠️ No Changeset found

Latest commit: b01878a3d9478612c2ee1bb54c9e5c84a0be4c59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 02 '24 13:01 changeset-bot[bot]

Someone is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 02 '24 13:01 vercel[bot]

@kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p

luluhoc avatar Jan 02 '24 18:01 luluhoc

@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later

adrien2p avatar Jan 03 '24 08:01 adrien2p

@luluhoc we will have a review as soon as we can, but don't change the version of the package manually. It is done automatically by the changeset later

@adrien2p ok, thanks. I reverted the package version to the original

luluhoc avatar Jan 03 '24 08:01 luluhoc

any news? @kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p

luluhoc avatar Jan 28 '24 17:01 luluhoc

any news?

luluhoc avatar Feb 17 '24 13:02 luluhoc

There is also a major error in docs after the recent push order_shipped_template should be order_shipment_created_template

I already tested it in my production

@kasperkristensen @pKorsholm @riqwan @olivermrbl @adrien2p

luluhoc avatar Feb 28 '24 11:02 luluhoc

bump

luluhoc avatar Apr 29 '24 18:04 luluhoc

Sorry for the lack of response, we are currently focused on medusa 2.0 but we will get back to you 👍

adrien2p avatar Apr 30 '24 05:04 adrien2p

Hey @luluhoc , as the architecture of how notifications in v2 changed significantly, We will close this PR. Thanks for the contribution though, I hope at the very least helped you got a better understanding of Medusa, and we'll be looking forward to your contributions again!

sradevski avatar May 15 '24 07:05 sradevski

@sradevski Hey, I understand that it may not be suitable for v2, although it fixes some problems with the plugin in 1.x so it still could have been merged to 1.x train.

luluhoc avatar May 15 '24 12:05 luluhoc

@luluhoc if there is a bug that needs fixing, let's have a PR just for that fix. Converting to TS shouldn't be a requirement to do that, as it makes it much more time-consuming for us to review it, without a long-term benefit.

sradevski avatar May 15 '24 12:05 sradevski