medusa
medusa copied to clipboard
docs/Improve Docker Documentation
issue# 1910
⚠️ No Changeset found
Latest commit: 1985dd8409d104556dad83a51a46344f30708467
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@shahednasser please review the required changes and tell me if anything else is required. Thanks!
@shahednasser please review the changes . Thanks!
done please check
On Mon, Sep 26, 2022 at 11:12 AM Shahed Nasser @.***> wrote:
@.**** commented on this pull request.
In www/docs/sidebars.js https://github.com/medusajs/medusa/pull/2248#discussion_r980166004:
{
type:"doc",id: "quickstart w Docker",label :"Quickstart Docker",},Also, for the id property the value should be quickstart/quick-start-docker. And remove the label.
— Reply to this email directly, view it on GitHub https://github.com/medusajs/medusa/pull/2248#discussion_r980166004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPFB66AHKNSJIFZ3CVCU7TWAG4NFANCNFSM6AAAAAAQTEJDXQ . You are receiving this because you were mentioned.Message ID: @.***>
Amazing work @sabakhilji thank you 🚀
thanks, @shahednasser for the guidance and support
done
On Mon, Sep 26, 2022 at 11:29 AM Shahed Nasser @.***> wrote:
@.**** requested changes on this pull request.
In www/docs/sidebars.js https://github.com/medusajs/medusa/pull/2248#discussion_r980195872:
@@ -30,6 +30,11 @@ module.exports = { id: "quickstart/quick-start", label: "Quickstart Guide", },
{type:"doc",id: "quickstart w Docker",for the id property the value should be quickstart/quick-start-docker
In www/docs/sidebars.js https://github.com/medusajs/medusa/pull/2248#discussion_r980195948:
@@ -30,6 +30,11 @@ module.exports = { id: "quickstart/quick-start", label: "Quickstart Guide", },
{type:"doc",id: "quickstart w Docker",label :"Quickstart Docker",Remove the label.
— Reply to this email directly, view it on GitHub https://github.com/medusajs/medusa/pull/2248#pullrequestreview-1120459652, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPFB632PTEMBAYIZMIDC7LWAG6ONANCNFSM6AAAAAAQTEJDXQ . You are receiving this because you were mentioned.Message ID: @.***>