medusa icon indicating copy to clipboard operation
medusa copied to clipboard

chore: apply prettier on pipeline

Open carlos-r-l-rodrigues opened this issue 2 years ago • 3 comments

what: Apply Prettier to all files from a pull request

carlos-r-l-rodrigues avatar Aug 30 '22 17:08 carlos-r-l-rodrigues

⚠️ No Changeset found

Latest commit: f5dfaaa13971cd1dc4acc9731c4a484dae835cbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 30 '22 17:08 changeset-bot[bot]

Re running a linting fix (comment from #2130): Would it make sense to break it down into domains or layers? Just ran the lint in medusa/packages/medusa and we currently have > 100,000 places to fix.

olivermrbl avatar Sep 05 '22 16:09 olivermrbl

suggestion: We could scope the automated linting to our core and run a check instead of writing directly - again, to avoid nasty surprises. The job in the workflow would look something like this:

...
jobs:
  format:
    runs-on: ubuntu-latest
    steps:
      - name: Check out repo
        uses: actions/checkout@v2
      - name: Run prettier
        run: |-
          npx prettier -c 'packages/medusa/**/*.{js,ts,json}' 

olivermrbl avatar Sep 07 '22 10:09 olivermrbl