medusa icon indicating copy to clipboard operation
medusa copied to clipboard

Fix import of InMemConfig

Open MortadaAK opened this issue 3 years ago • 2 comments

There is an issue with the import where the file exports the class as exports.InMemoryConfigStore not exports.default

and the output is

/app/medusa/node_modules/medusa-telemetry/dist/store.js:37
      this.config_ = new _inMemoryConfig["default"]();
                     ^
TypeError: _inMemoryConfig.default is not a constructor
    at new Store (/app/medusa/node_modules/medusa-telemetry/dist/store.js:37:22)
    at new Telemeter (/app/medusa/node_modules/medusa-telemetry/dist/telemeter.js:42:19)
    at Object.<anonymous> (/app/medusa/node_modules/medusa-telemetry/dist/index.js:20:17)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Object.require.extensions.<computed> [as .js] (/app/medusa/node_modules/ts-node/src/index.ts:1445:43)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)

MortadaAK avatar Aug 30 '22 12:08 MortadaAK

🦋 Changeset detected

Latest commit: 9257730e182a2e85b719bdd958dc7301b969ec73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-telemetry Patch
@medusajs/medusa-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 30 '22 12:08 changeset-bot[bot]

Thanks for the contribution and nice spotted. Can I get you to rebase off develop? I've changed the base branch.

olivermrbl avatar Sep 07 '22 09:09 olivermrbl

Any works around. We are impacted in version 1.4.1 when we lauch medusa migrations run

Guillaume-Dufour avatar Nov 08 '22 15:11 Guillaume-Dufour

Will be part of v1.6.2 👍

olivermrbl avatar Nov 09 '22 16:11 olivermrbl

For some reason, the PR won't pass the CI. I will have to close and open a new one. But many thanks for the contribution 💪

olivermrbl avatar Nov 09 '22 16:11 olivermrbl