medusa icon indicating copy to clipboard operation
medusa copied to clipboard

fix(medusa): Complete cart with 100% discount

Open olivermrbl opened this issue 3 years ago • 1 comments

What Naive fix to allow carts with 100% discount to be completed.

Why Discount total is wrongly calculated if items and items.adjustments is not included in relations upon retrieving the cart.

Thought This is yet another example of why we need to rethink and refactor totals computation to not depend on what is provided by the user.

olivermrbl avatar Aug 10 '22 19:08 olivermrbl

⚠️ No Changeset found

Latest commit: 845f85a2c9a0d78eaa2ca09f2359dd86c22f48c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 10 '22 19:08 changeset-bot[bot]