medusa icon indicating copy to clipboard operation
medusa copied to clipboard

feat(medusa): spread config to have custom props in config

Open Inoir opened this issue 3 years ago • 1 comments

As i mentioned here: https://github.com/medusajs/medusa/issues/1837 custom props getting stripped of the config. Results in problems in seeding with custom logic and custom props in config, cause there is no way to get this custom props into the service loader i.e.

This allows custom props in the config and still preserves the reserved config from medusa.

Question here is should the custom props inside an object called "customConfig" like @srindom suggested in the issue? currently i dont see the point in changing the config from the real one loaded.

Inoir avatar Jul 23 '22 18:07 Inoir

⚠️ No Changeset found

Latest commit: 4c933654b987f714302f50793dc6e5b41f5dd280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 23 '22 18:07 changeset-bot[bot]