medusa icon indicating copy to clipboard operation
medusa copied to clipboard

add images to product collections

Open edihasaj opened this issue 2 years ago • 5 comments

add thumbnail and image properties to product-collection.ts. add api endpoint changes for managing thumbnail and image. add migration changes for product collection images add new endpoint for querying collection with products and images included (joined) /store/collections/:id/products add integration test for new created endpoint. add docs changes for product-collection entity changes add docs for the new added endpoint.

edihasaj avatar Jul 05 '22 19:07 edihasaj

⚠️ No Changeset found

Latest commit: 069c0ae66f42be09a9969686d58e7e7af80669a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 05 '22 19:07 changeset-bot[bot]

@srindom Is this okay?

changes are based on PR #1767 and #1769

edihasaj avatar Jul 05 '22 19:07 edihasaj

I am also developing the remaining part in integrating medusa admin with the added functionality above.

edihasaj avatar Jul 06 '22 23:07 edihasaj

Requested functionality for querying imageRepository from DI, doesn't recognize the upsertImages() method, so I'm converting the services/product-collection.js to typescript. I'll test it and I'll let you know for review continutation

edihasaj avatar Jul 07 '22 15:07 edihasaj

@kasperkristensen you can now review the changes.

edihasaj avatar Jul 07 '22 16:07 edihasaj