medusa icon indicating copy to clipboard operation
medusa copied to clipboard

Bug: Resent notification replaces parent notification

Open shahednasser opened this issue 3 years ago • 1 comments

If a notification is resent using the Resend Notification endpoint, the resent notification replaced the original notification instead of creating a new one that is associated with the original notification using the parent_id.

This is mainly because of the following lines in the resend method in the NotificationService:

https://github.com/medusajs/medusa/blob/2eb2126fe348565721e05e6f0da01c46bad6185a/packages/medusa/src/services/notification.js#L250-L255

The id field should be set as null or removed from the notification object before its data is used to create the new notification.

shahednasser avatar Jun 09 '22 10:06 shahednasser

Happy to accept PRs for this!

  • the PR should include an integration test to verify that the notification is not replaced

srindom avatar Aug 09 '22 09:08 srindom

Hey @srindom, can I work on this?

Wahaj404 avatar Aug 13 '22 20:08 Wahaj404

Hey @srindom, can I work on this?

Yes! Please do :)

srindom avatar Aug 17 '22 15:08 srindom

Hi, @srindom I would like to work on this one

SounakB avatar Sep 10 '22 13:09 SounakB

Raised a PR for this:- #2178

prabureddy avatar Sep 11 '22 00:09 prabureddy