medusa icon indicating copy to clipboard operation
medusa copied to clipboard

fix: allow null updates in discounts

Open pKorsholm opened this issue 3 years ago • 3 comments

What

  • allow nulls in the update dto for promotions for: ends_at, valid_duration and usage_limit

Why

  • to enable the admin client to remove the previously mentioned properties using the medusa-react client

pKorsholm avatar Apr 05 '22 09:04 pKorsholm

@pKorsholm could you update the types in the entity as well please 😊

adrien2p avatar Apr 05 '22 11:04 adrien2p

@pKorsholm could we add an integration test for that please :)

adrien2p avatar Jun 30 '22 09:06 adrien2p

⚠️ No Changeset found

Latest commit: 17bf3ff7fcf4791791fcd3a9eb4e3c7cfe4328cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 01 '22 12:07 changeset-bot[bot]

Fixed in #1545 but we might as well include these tests :)

olivermrbl avatar Aug 21 '22 10:08 olivermrbl