admin icon indicating copy to clipboard operation
admin copied to clipboard

feat: price list bulk edit table

Open fPolic opened this issue 2 years ago • 6 comments

What

  • add the price list bulk edit table

Depends on

  • https://github.com/medusajs/medusa/pull/1503

TODO

  • [x] add pagination (design + new ticket?)
  • [x] horizontal scroll

fPolic avatar May 01 '22 18:05 fPolic

Deploy Preview for nostalgic-booth-1cf149 failed.

Name Link
Latest commit dab2bef9ad669cf3a50c970b08c495ad3cad655a
Latest deploy log https://app.netlify.com/sites/nostalgic-booth-1cf149/deploys/627136b4f332fd000848b921

netlify[bot] avatar May 01 '22 18:05 netlify[bot]

Deploy Preview for tekla-admin ready!

Name Link
Latest commit dab2bef9ad669cf3a50c970b08c495ad3cad655a
Latest deploy log https://app.netlify.com/sites/tekla-admin/deploys/627136b4ec6cbd0009831c10
Deploy Preview https://deploy-preview-540--tekla-admin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 01 '22 18:05 netlify[bot]

Deploy Preview for palmes-staging-admin ready!

Name Link
Latest commit c0f4e18e5d0501b578a7fa4a7152e1b408c2366a
Latest deploy log https://app.netlify.com/sites/palmes-staging-admin/deploys/62934aa2092c850008450616
Deploy Preview https://deploy-preview-540--palmes-staging-admin.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 01 '22 18:05 netlify[bot]

Deploy Preview for preeminent-gingersnap-0af4e1 ready!

Name Link
Latest commit dab2bef9ad669cf3a50c970b08c495ad3cad655a
Latest deploy log https://app.netlify.com/sites/preeminent-gingersnap-0af4e1/deploys/627136b498f9be000855d08c
Deploy Preview https://deploy-preview-540--preeminent-gingersnap-0af4e1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 01 '22 18:05 netlify[bot]

Deploy Preview for elastic-keller-bcaedb ready!

Name Link
Latest commit dab2bef9ad669cf3a50c970b08c495ad3cad655a
Latest deploy log https://app.netlify.com/sites/elastic-keller-bcaedb/deploys/627136b4e04e14000881d04a
Deploy Preview https://deploy-preview-540--elastic-keller-bcaedb.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 01 '22 18:05 netlify[bot]

One thing (and this might just be my preference) I think it would be cool to create something like a components folder in the bulk-editor folder in order to separate the components a bit and to decrease the size of the file.

I find it easier to work on a feature if it is "contained" in a single file (no need to jump between files), but it is a bit harder to review that way 😬. I agree that it would make sense to split the components into separate files in case components are used outside of bulk-editor, but since we only export BulkEditorContainer I would leave it this way for now.

fPolic avatar May 24 '22 08:05 fPolic