semantic-sdp-js MediaInfo.codecs type confuse

MediaInfo.codecs type confuse

Open notedit opened this issue 5 years ago • 5 comments

in this line
https://github.com/medooze/semantic-sdp-js/blob/master/lib/MediaInfo.js#L159 the codecs type is Map<string, CodecInfo>

and in this line
https://github.com/medooze/semantic-sdp-js/blob/master/lib/MediaInfo.js#L151 the codes type is Map<int, CodecInfo>

we should make them the same.

Oct 23 '18 05:10 notedit

should be Number

Nov 21 '18 09:11 murillo128

thanxs for spotting that out!

Nov 21 '18 10:11 murillo128

@murillo128 we should check this too https://github.com/medooze/semantic-sdp-js/blob/f815d256b3719062987a2d29269563d117972ca1/lib/MediaInfo.js#L451

CodecInfo.MapFromNames still return Map<string, CodecInfo>

Nov 21 '18 11:11 notedit

https://github.com/medooze/semantic-sdp-js/blob/master/lib/MediaInfo.js#L177

getCodec should return array or map too. Chrome has three profiles for h264 codec.

Dec 11 '18 15:12 notedit

This would be backward incompatible, I would propose to add a new method with different name instead

Dec 11 '18 15:12 murillo128