Gavin Medley comments

Results 41 comments of


                                            Gavin Medley

Add straightforward endianness implementation; accommodate all allowable string encodings

Ok. I'll take over this PR branch and start working on tests.

Fix incorrect parsing of `StringDataEncoding` element

@cgobat In reading through the green book I realized there are some fundamental issues with the way we use StringDataEncoding. I think these issues are mostly separate from the work...

Use `lxml` instead of standard library `xml` to improve namespace identification

Hi @cgobat, thanks for submitting some of the first PRs for this project! Can you briefly explain why the namespace reading benefit is worth adding a new dependency to the...

Use `lxml` instead of standard library `xml` to improve namespace identification

Nice. Thank you for writing that up! It sounds reasonable to me and your point about the mapping for the namespace is a good one. On your question about bumping...

Use `lxml` instead of standard library `xml` to improve namespace identification

There are some tests that need to be updated to use the new xml library though. test_xtcedef.py uses xml.etree.ElementTree and that should be a quick fix I think. I also...

Avoid reading the header twice during packet parsing

https://github.com/medley56/space_packet_parser/pull/79#discussion_r1778803200

Add a schema validator / checker

Here is a little example of doing schema validation with lxml. TIL that `author` is not a valid field in the XTCE Header and that `validationStatus` is a required field......

Add a schema validator / checker

@cgobat That's great! Do you want to own this feature or would you rather someone else use that as a starting point? I would like to add automatic retrieval of...

Add a schema validator / checker

Yeah, let's avoid another dependency if we don't need it. If we start doing a lot of HTTP requests for some other reason, then let's consider including requests.

Add a schema validator / checker

And as for fetching XML online, it is technically a security vulnerability since parsing XML with lxml is vulnerable to things like XML bombs if you're using an old version...