self-node-remediation
self-node-remediation copied to clipboard
medik8s
Support Multiple Same Kind Remediation
Why we need this PR
This PR will enable the user to select several SNR Templates (of the same kind) when using NHC escalating remediation.
This feature is dependent on the changes in NHC as well (which is available starting from NHC 0.8.0).
Changes made
- Automatically add the
MultipleTemplatesSupportedAnnotationthat enables this feature via "Defaulting" (Mutating) webhook. - Support that Node's name might come from
NodeNameAnnotationinstead than from remediation's name (when the feature is enabled). - Updated Common package to the version shipping the new annotations needed by this feature.
- Test coverage for both configurations (supported and unsupported multiple same kind remediation).
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-1930
Test plan
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano, slintes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [clobrano,slintes]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
the problem on 4.16 does not depend on us /override "ci/prow/4.16-openshift-e2e"
@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.16-openshift-e2e
In response to this:
the problem on 4.16 does not depend on us /override "ci/prow/4.16-openshift-e2e"
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.