node-healthcheck-operator
node-healthcheck-operator copied to clipboard
Build a file-based catalog
Why we need this PR
Currently NHC's Makefile creates a db-based catalog, which is deprecated
DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.
Changes made
This change creates a file-based catalog
https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-1948
Test plan
- create the file-based catalog and push it to my quay.io repository via Makefile
- create a CatalogSource pointing to the new catalog
- install FAR via WebUI, verify that everything works
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [clobrano]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
interesting, it seems kind isn't happy with this change
2024/04/05 17:09:58 render reference "kind-registry:5000/node-healthcheck-operator-bundle:latest": error resolving name for image ref kind-registry:5000/node-healthcheck-operator-bundle:latest: failed to do request: Head "https://kind-registry:5000/v2/node-healthcheck-operator-bundle/manifests/latest": http: server gave HTTP response to HTTPS client
I am testing the k8s-e2e phase, do not merge /hold