cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

fix(#9739): deselecting "Select all" deselects all reports

Open anurag2787 opened this issue 7 months ago • 4 comments

Description

The issue was happening because of scroll loading when we select all reports using checkbox it only selects the reports that are loaded but many reports are still not loaded due to lazy loading so when we uncheck the select all checkbox it doesn't actually deselect anything.

To fix this i added a change so that when select all is clicked it fetches all reports first. That way deselecting works properly on the full list.

ISSUE NUMBER

Closes #9739

Before Changes

https://github.com/user-attachments/assets/8fe7df15-71e2-4845-be0c-78538ab68b10

After Changes

https://github.com/user-attachments/assets/4b95a26b-c7aa-4e02-a361-251a7b64644b

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

anurag2787 avatar May 03 '25 08:05 anurag2787

Hy @dianabarsan I have fixed the issue, please review Thank you!

anurag2787 avatar May 03 '25 08:05 anurag2787

Hi @dianabarsan I have fixed the sonar issue to reduce cognitive complexity and updated to use nullish coalescing.

anurag2787 avatar May 03 '25 17:05 anurag2787

Hy @dianabarsan i have pushed my code please review. Implemented the change so that when the Select All checkbox is clicked it gets disabled once all the reports are fully loaded the checkbox is re-enabled

anurag2787 avatar Jun 10 '25 05:06 anurag2787

Hi, i have fixed linting issues and renamed it as per your suggestion. Please review it whenever you get time Thanks!

anurag2787 avatar Jun 10 '25 08:06 anurag2787

@anurag2787 are you still planning to work on this issue? If yes, can you please review @dianabarsan's comments? If not, please close the PR. Thank you!

andrablaj avatar Jun 25 '25 14:06 andrablaj