cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

feat(#8551): removes python from cht-deploy and some bug fixes

Open henokgetachew opened this issue 9 months ago • 3 comments

Description

Handles the following tickets:

#8551 Remove python - establishing feature parity. No major refactoring. #8604 Catch Missing Values #8605 Show URL when done execution #8608 Add a get-all-logs troubleshooting command

Code review checklist

  • [ ] Readable: Concise, well named, follows the style guide, documented if necessary.
  • [ ] Documented: Configuration and user documentation on cht-docs
  • [ ] Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

henokgetachew avatar Apr 29 '24 11:04 henokgetachew

Comments addressed. A few tests added and build is passing. Also integrated with CI. This puts us in a better spot that we can iterate on.

henokgetachew avatar May 25 '24 10:05 henokgetachew

@nydr yes, I've actually already published this to npm. https://www.npmjs.com/package/@medic/cht-deploy. It can be run via npx @medic/cht-deploy -f <path-to-your-yaml>

henokgetachew avatar May 28 '24 12:05 henokgetachew

We need this fix. What's pending so it gets merged?

latin-panda avatar Jun 26 '24 05:06 latin-panda

@henokgetachew @mrjones-plip I know it's been busy lately. Is there anything we can do to help this PR?

We are currently pulling from a commit (4760b5d30017a86d90ae95b1d570ba9ed6d053dc) to keep using EKS instances. Especially to verify issues during releases in CHT, so fixing and merging this PR will help the release managers to not rediscover the same issue error: InvalidImageName in the upgrade service.

Screenshot 2024-08-15 at 4 55 04 PM

latin-panda avatar Aug 15 '24 09:08 latin-panda

I can confirm that this worked for me when testing out the upgrade to release 4.10.0 when the demo instance was not working.

sugat009 avatar Aug 15 '24 09:08 sugat009

This is actually on my plan for today. Until the merge by the way, you should be able to use: npx @medic/cht-deploy@latest -f <your-yaml.yaml>

henokgetachew avatar Aug 15 '24 10:08 henokgetachew

Thanks for the push @latin-panda ! Much appreciated.

We are currently pulling from a commit (4760b5d30017a86d90ae95b1d570ba9ed6d053dc) to keep using EKS instances.

At the point this is true, we just need to merge the branch. If everyone is using the branch as production, there's simply no reason to not merge it. We can create new tickets for work that wasn't completed.

Great to see you making some commits on this Henok! Given this is in production use already, we should commit to merging this either way before week's end. I'm available to help as needed!!

mrjones-plip avatar Aug 15 '24 14:08 mrjones-plip

Agreed. That's the plan.

henokgetachew avatar Aug 15 '24 15:08 henokgetachew