cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

Replace all FontAwesome icons with svg icons #5535

Open elvisdorkenoo opened this issue 2 years ago • 1 comments

Description

Replace all FontAwesome icons with svg icons #5535

[description] Following the steps of these suggestions medic/cht-core#5535

FA 4 -> FA 6 steps :

  • [ ] 1. Install FA 6 and make the webapp project run (testable)
  • [ ] 2. load and test FA 6 css icons (testable)
  • [ ] 3. load and test FA 6 svg icons (testable)
  • [ ] 4. Upgrade admin app FA 4 to FA 6 (not yet)
  • [ ] 5. Change the icons to the news ones (testable)
  • [ ] 6. Re-style/ customize svg icons to match our design (testable)
  • [ ] 7. Change all png custom icons to svg versions (testable except logo icon.png)
  • [ ] 8. Upload our own custom icons to FA ? use FA Pro ? (not yet)
  • [ ] 9. Test and adjust(eventually) icons for mobile version(not yet)
  • [ ] 10. Update e2e tests (testable)
  • [ ] 11. Backwards compatibility, make sure nothing is broken or fix if something is broken, check svg icons loading and offline metrics (testable)

Code review checklist

  • [ ] Readable: Concise, well named, follows the style guide, documented if necessary.
  • [ ] Documented: Configuration and user documentation on cht-docs
  • [ ] Tested: Unit and/or e2e where appropriate
  • [ ] Internationalised: All user facing text
  • [ ] Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

elvisdorkenoo avatar Jun 07 '22 13:06 elvisdorkenoo

@elvisdorkenoo I think we decided not to go ahead with this. Should we close this PR off?

garethbowen avatar Aug 04 '22 03:08 garethbowen

Closing. Feel free to reopen if I've missed something.

garethbowen avatar Aug 31 '22 18:08 garethbowen