cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

E2E tests fail on MacOS

Open njogz opened this issue 3 years ago • 1 comments

Describe the bug Running transition end to end tests fails on MacOS. The bug was traced to the package we use to read logs

To Reproduce Steps to reproduce the behavior:

  1. Use a MacOS device (haven't experienced on other OSs yet)
  2. Run the sentinel_api_transitions.spec.js e2e test
  3. Notice tests fail. Add a catch block to any of the tests if the error message is not descriptive

Expected behavior E2e tests pass locally on MacOS as they do on linux

Additional context Using https://github.com/g-script/better-tail fixes the issue but I broke some other e2e tests when I used it.

njogz avatar May 07 '21 08:05 njogz

With archv3, we are no longer using any external library to tail logs, instead we use docker logs <container> -f . https://github.com/medic/cht-core/blob/83089534226abde29cf50492d754a0009eccb9aa/tests/utils.js#L435-L436 We should confirm that this new approach works on Mac OS and close this issue.

dianabarsan avatar Apr 29 '22 13:04 dianabarsan

@njogz If you have a moment, could you please check if this is still an issue?

garethbowen avatar Aug 02 '23 02:08 garethbowen

@njuguna-n is this issue still happening? Can you please check and close the ticket if not relevant anymore?

andrablaj avatar Mar 18 '24 10:03 andrablaj

I ran the e2e suite with 4.6 on macOS (Apple Silicon chip) and tests are passing.

Screenshot 2024-04-09 at 15 59 26

Closing this issue as the macOS test problems were fixed in higher versions of the CHT, as @dianabarsan mentioned above.

andrablaj avatar Apr 09 '24 16:04 andrablaj