cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

Remove custom translations from Bamanankan

Open kennsippell opened this issue 4 years ago • 6 comments

Describe the issue PR https://github.com/uxsolutions/bootstrap-datepicker/pull/2431 was created to add Bamanankan to the bootstrap datepicker library. Until it was released, we added custom translations at https://github.com/medic/cht-core/blob/master/webapp/src/js/enketo/bootstrap-datepicker.bm.js.

Describe the improvement you'd like Bump bootstrap-datepicker to latest and remove custom translations.

kennsippell avatar Jan 14 '21 21:01 kennsippell

We bump dependencies (almost) every minor release, so I'll add this to 3.12.0 to be done at the same time.

garethbowen avatar Jan 14 '21 21:01 garethbowen

This will be sorted out with the enketo-core uplift

njogz avatar Jan 20 '22 10:01 njogz

@njogz so this is ready for AT on the enketo core uplift branch?

dianabarsan avatar Jan 25 '22 11:01 dianabarsan

@dianabarsan yes it is.

njogz avatar Jan 25 '22 12:01 njogz

Removing from the 3.14 milestone as the enketo uplift has been postponed. Keeping it in AT.

ngaruko avatar Jan 26 '22 01:01 ngaruko

Config: Default
 Environment: Local with docker helper script
 Platform: WebApp
 Browser: Chrome

Test Scenario. Using Bamanankan language, the date picker is showing as it should be in the 6345-enketo-uplift branch.

  • Master image

  • 6345-enketo-uplift image

tatilepizs avatar Mar 01 '22 15:03 tatilepizs