cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

Published 20 hours ago • verified publisher icon medic

Record test coverage

Open garethbowen opened this issue 5 years ago • 6 comments

Describe the issue We don't have an easy way to tell which code is well tested and which isn't, or if a change is reducing or improving coverage.

Describe the improvement you'd like

  1. Update our testing grunt tasks (karma, mocha, and if possible protractor) to produce a report of which lines of code are touched during testing. This report should be gitignored.
  2. Publish the results somewhere (AWS?) during CI.
  3. Find some way to diff the results between the branch and master so they can be compared when doing a code review.

Describe alternatives you've considered None.

Timebox Don't spend more than two days on this. If it's too hard to do with our current stack then we can delay it until we redo our stack (after Angular 8). If you only get the first task done in the time allowed then get that merged and we can come back to the CI improvements later.

garethbowen avatar Sep 08 '19 22:09 garethbowen

Blocked waiting for Angular++

garethbowen avatar Mar 03 '20 03:03 garethbowen

@dianabarsan Is this solved now?

garethbowen avatar Feb 28 '21 22:02 garethbowen

This is done for webapp. My opinion is to also add code coverage to API and Sentinel at least, if not to all shared libs as well.

dianabarsan avatar Mar 01 '21 05:03 dianabarsan

Ok, good call. Leaving open for now.

garethbowen avatar Mar 01 '21 20:03 garethbowen

This PR added unit test coverage for API and Sentinel. I think we should also do it for shared libs so I'm keeping this issue open until then.

dianabarsan avatar Jan 13 '24 04:01 dianabarsan

Added coverage summary for shared libraries as well. There is no integration with CI and results aren't stored anywhere (except for CI logs).

dianabarsan avatar Jan 16 '24 14:01 dianabarsan