cht-core icon indicating copy to clipboard operation
cht-core copied to clipboard

How we refer to fields in the reminder vs registrations is not consistent

Open henokgetachew opened this issue 8 years ago • 4 comments

In registrations you need to use doc.fields.{field_name} whereas in the schedules config you need fields.{field_name}. This is confusing and easy to miss. We should make this consistent.

henokgetachew avatar Mar 14 '17 15:03 henokgetachew

There are also places where you can just use {field_name}

abbyad avatar Mar 14 '17 15:03 abbyad

We should also either include errors on the doc or log decent errors/warnings when those configurations are not resolved properly.

mandric avatar Mar 14 '17 16:03 mandric

@mandric that last bit is raised in a separate issue here: https://github.com/medic/medic-webapp/issues/3232

henokgetachew avatar Mar 14 '17 18:03 henokgetachew

I think it is worth making these consistent, by merging strategies so that all the different ways work with all others. That will improve consistency without requiring migration. Other opinions welcome.

SCdF avatar Feb 01 '18 10:02 SCdF