cht-android icon indicating copy to clipboard operation
cht-android copied to clipboard

FEAT: added eCHIS Kenya Training & Testing Instances & updated branding

Open karimkkanji opened this issue 1 year ago • 9 comments

This pull request does the following things:

  1. Adds a new entry to the domains list for training instances: https://chis-4-testing.health.go.ke
  2. Updates the Titles to now show "eCHIS" instead of CHIS
  3. Updates assets due to the assets not previously tracked.

karimkkanji avatar Sep 19 '24 14:09 karimkkanji

@alexosugo once done, will this be in playstore? I really dont want the CHPs to use the browser.

christinawere avatar Sep 20 '24 11:09 christinawere

@alexosugo once done, will this be in playstore? I really dont want the CHPs to use the browser.

@christinawere finalising testing locally

karimkkanji avatar Sep 20 '24 11:09 karimkkanji

I've made an attempt to regenerate secrets using the keystore provided by Ian and the bundle signing key ended up being different so training cannot be updated. I'm attaching it here if anyone needs to review. secrets-chis_kenya.tar.gz We'll have to republish the training app.

eljhkrr avatar Sep 26 '24 10:09 eljhkrr

@eljhkrr When was the training last updated on Play Store and do we know by whom? I assume that by removing and republishing the app afresh, the review time will be longer since it'll be treated as a new app.

alexosugo avatar Sep 26 '24 12:09 alexosugo

Last update was in September 2023 probably by Ian who has since left MoH. We've tried getting credentials used then and they're not the same as used to publish to the playstore. It's a one-time thing, once we have automated builds setup, publishing updates will be a lot smoother.

eljhkrr avatar Sep 26 '24 13:09 eljhkrr

We've published an update to the app and can merge after secrets have been setup

eljhkrr avatar Oct 04 '24 16:10 eljhkrr

I can help add secrets to this repo. Is it correct that we just need these 4 added?

ANDROID_SECRETS_KEY_CHIS_KENYA
ANDROID_SECRETS_IV_CHIS_KENYA
ANDROID_KEY_PASSWORD_CHIS_KENYA
ANDROID_KEYSTORE_PASSWORD_CHIS_KENYA

The other two in 1pass don't need a secret as far as I can tell as their common knowledge. GH has an upper bounds of secrets so we want to use them sparingly.

mrjones-plip avatar Oct 08 '24 14:10 mrjones-plip

Thanks @mrjones-plip, just the 4 will do

eljhkrr avatar Oct 08 '24 14:10 eljhkrr

3 secrets created. I did not create ANDROID_KEY_PASSWORD_CHIS_KENYA . Please use ANDROID_SECRETS_KEY_CHIS_KENYA instead as it has the same value.

mrjones-plip avatar Oct 08 '24 14:10 mrjones-plip