MediathekViewMobile icon indicating copy to clipboard operation
MediathekViewMobile copied to clipboard

Publish on FDroid

Open sepo83 opened this issue 3 years ago • 6 comments

In the README you announced to publish the app on FDroid. Did you already start? If not I would offer some help; e.g. adapt your repo (e.g. create a pull request that adds metadata in fastlane structure) and prepare the merge-request to the fdroiddata repo.

sepo83 avatar Mar 21 '21 14:03 sepo83

That would be amazing. I actually already started looking into it, but have postponed it after realizing that it is not as trivial as I thought.

Sorry I have been quite busy in the last few days and haven't monitored the issues properly.

danielfoehrKn avatar Apr 03 '21 18:04 danielfoehrKn

I have prepared most things:

  • see my pull request for adapting your repo/app --> see https://github.com/mediathekview/MediathekViewMobile/pull/6
  • metadata-file which fdroid uses to build your app
    • see https://gitlab.com/sepo83/fdroiddata/-/blob/master/metadata/com.mediathekview.mobile.yml
    • currently it is pointing to my fork of the app --> we have to change this to your repo as soon you made a release with all the necessarry adaptions

I can basically build your app (my fork) with the fdroid toolchain. However, it complains about the included binary android-smartview-sdk-2.5.1.jar. I think on fdroid they do not like binaries with "unknown" content resp. without sourcecode. Can you replace that binary? Either by using an alternative with published sources or remove it (at least for fdroid builds).

sepo83 avatar Apr 05 '21 14:04 sepo83

After solving the above mentioned issue the next steps would be:

  1. check the fdroiddata metadata file I have prepared (https://gitlab.com/sepo83/fdroiddata/-/blob/master/metadata/com.mediathekview.mobile.yml)
    • esp. check metadata like Categories, License, AuthorName, SourceCode, etc
    • check build instructions --> with this and the chnges from my PR I can build the app locally (currently only with --skip-scan in order to workaround the included binary issue from above)
  2. make a new release that includes all necessary changes (my PR + solving the included binary issue) and come back to me
    • I would sugest your tag the (future) releases with v<major>.<minor>.<patch> as it is also sugested by github
    • I will adapt com.mediathekview.mobile.yml for frdoiddata to the new release from step 2 and do a "final check"
  3. Finally you should do the merge-request to the fdroiddata-repo with the following steps:
    • fork the fdroiddata repo from https://gitlab.com/fdroid/fdroiddata
    • add metadata/com.mediathekview.mobile.yml from my fork https://gitlab.com/sepo83/fdroiddata
    • optionally redo the steps fdroid supposes at https://gitlab.com/fdroid/fdroiddata/-/blob/master/CONTRIBUTING.md
    • check the gitlab pipeline output of your fdroiddata-fork
    • do a merge request to the original fdroiddata repo
      • make sure you give them write acess to your merge request
      • they will do a review of your app and usually have a few suggestions/questions to you
    • after it is merged your app will be published with the next scheduled build-run on fdroid

New releases will be automtically published on fdroid. For this fdroiddata regulary extracts the latest version from pubspec.yml (master-branch) and looks for a git tag with this version.

Thanks for your great app!!!

sepo83 avatar Apr 05 '21 15:04 sepo83

Thanks for the detailed guide & the help!

The binary it complains about is used for casting videos to Samsung TVs - unfortunately, it is not open source. I'll try to create a flavor that excludes this binary (no TV casting for fdroid versions).

danielfoehrKn avatar Apr 05 '21 20:04 danielfoehrKn

Still working on removing the Samsung library in the fdroid build flavor. Having not much capacity to work on it though atm. Has to wait unfortunately still a bit.

danielfoehrKn avatar Apr 19 '21 12:04 danielfoehrKn

Any updates on this?

codenyte avatar May 05 '24 22:05 codenyte