screenpipe icon indicating copy to clipboard operation
screenpipe copied to clipboard

fix(build): Fix hardcoded vcpkg.exe path in pre_build.js(#752)

Open Tianion opened this issue 1 year ago • 1 comments


name: pull request about: Fix hardcoded vcpkg.exe path in pre_build.js title: "[pr] fix(build): Fix hardcoded vcpkg.exe path in pre_build.js(#752)" labels: 'bug' assignees: ''


description

Use VCPKG_ROOT for vcpkg.exe path.

related issue: #752

type of change

  • [x] bug fix
  • [ ] new feature
  • [ ] breaking change
  • [ ] documentation update

how to test

add a few steps to test the pr in the most time efficient way. https://docs.screenpi.pe/docs/getting-started#windows-installation-experimental

SET PKG_CONFIG_PATH=xxxxx
SET VCPKG_ROOT=xxxx\vcpkg
SET LIBCLANG_PATH=xxxxx
cd screenpipe
rustup default stable
cargo build --release 
cd screenpipe-app-tauri
bun install
bun scripts\pre_build.js 

if relevant add screenshots or screen captures to prove that this PR works to save us time. image

checklist

  • [ ] MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
  • [x] i have read the CONTRIBUTING.md file
  • [ ] i have updated the documentation if necessary
  • [x] my changes generate no new warnings
  • [ ] i have added tests that prove my fix is effective or that my feature works

Tianion avatar Nov 26 '24 03:11 Tianion

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:54am

vercel[bot] avatar Nov 26 '24 03:11 vercel[bot]

feel like it will not work in CI/CD

someone sent similar PR before

our CI/CD runs on self-hosted windows VM FYI

are you sure this will work?

louis030195 avatar Nov 26 '24 16:11 louis030195

I am sure it will work. I found that the CI does not set the environment variables as documented. Next, I will add these environment variables to the CI, or should I only add VCPKG_ROOT? Doc:

SET PKG_CONFIG_PATH=V:\packages\vcpkg\packages\ffmpeg_x64-windows\lib\pkgconfig
SET VCPKG_ROOT=V:\packages\vcpkg
SET LIBCLANG_PATH=C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\Llvm\x64\bin

CI:

      - name: Run pre_build.js
        shell: bash
        run: bun ./scripts/pre_build.js
        working-directory: ./screenpipe-app-tauri

Tianion avatar Nov 27 '24 02:11 Tianion