screenpipe icon indicating copy to clipboard operation
screenpipe copied to clipboard

Use VCPKG_ROOT environment variable for vcpkg path in windows build script

Open ABucket opened this issue 1 year ago • 2 comments

I think we should use VCPKG_ROOT environment variable for vcpkg path in windows build script, since the windows installation guide set this env: SET VCPKG_ROOT=V:\packages\vcpkg

ABucket avatar Oct 22 '24 12:10 ABucket

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:25am

vercel[bot] avatar Oct 22 '24 12:10 vercel[bot]

why is this necessary?

louis030195 avatar Oct 22 '24 18:10 louis030195

why is this necessary?

In the getting started document, the instruction was cd V:\packages git clone https://github.com/microsoft/vcpkg.git and SET VCPKG_ROOT=V:\packages\vcpkg so if the build script directly use C:\\vcpkg\\vcpkg.exe, it is likely that it will throw an file not found error.

ABucket avatar Oct 23 '24 02:10 ABucket

thx

louis030195 avatar Oct 23 '24 02:10 louis030195


337 | 
338 | 	// Setup vcpkg packages with environment variables set inline
339 | 	await $`SystemDrive=${process.env.SYSTEMDRIVE} SystemRoot=${process.env.SYSTEMROOT} windir=${process.env.WINDIR} ${process.env.VCPKG_ROOT}\\vcpkg.exe install ${config.windows.vcpkgPackages}`.quiet()
                     ^
ShellError: Failed with exit code 1
 info: {
  "exitCode": 1,
  "stderr": "",
  "stdout": ""
}

      at new ShellError (12:16)
      at new ShellPromise (72:16)
      at BunShell (187:35)
      at D:\a\***\***\***-app-tauri\scripts\pre_build.js:339:8

Bun v1.1.32 (Windows x64)
Error: Process completed with e

reverting

louis030195 avatar Oct 23 '24 03:10 louis030195