screenpipe icon indicating copy to clipboard operation
screenpipe copied to clipboard

fix: build: ignore ~/.wgetrc to avoid interference

Open devnoname120 opened this issue 1 year ago • 1 comments
trafficstars


name: pull request about: submit changes to the project title: "[pr] fix: build: ignore ~/.wgetrc to avoid interference" labels: '' assignees: 'louis030195'


description

Users can define personal settings for wget in ~/.wgetrc. When the wget command is run it reads this configuration file by default and add the corresponding options. The scripts/pre_build.js script fails when some user options are specified in the configuration file because they conflict with the options that this script uses. The solution is to ignore this user configuration file.

related issue: ø

type of change

  • [x] bug fix
  • [ ] new feature
  • [ ] breaking change
  • [ ] documentation update

how to test

  1. Create a file ~/.wgetrc and just put timestamping = on inside.
  2. Run bun scripts/pre_build.js from screenpipe-app-tauri and confirm that wget errors out because -nc and --timestamp can't be combined.
  3. Move to this branch, and run bun scripts/pre_build.js again. This time around wget works properly.

checklist

  • [x] i have read the CONTRIBUTING.md file
  • [x] i have added the custom cursor AI prompt to my settings as mentioned in CONTRIBUTING.md and used to write this PR
  • [x] my code follows the project's style guidelines
  • [x] i have performed a self-review of my code
  • [x] i have updated the documentation if necessary
  • [x] my changes generate no new warnings
  • [x] i have added tests that prove my fix is effective or that my feature works
  • [x] all tests pass locally with my changes

additional notes

any other relevant information about the pr.

devnoname120 avatar Oct 19 '24 00:10 devnoname120