URI.js icon indicating copy to clipboard operation
URI.js copied to clipboard

jQuery Plugin - jQuery.expr[":"] is now jQuery.expr.pseudos

Open Airn5475 opened this issue 7 years ago • 3 comments

While updating our site to jQuery v3.1.1 I am having issues with the jQuery plugin using jQuery.expr.

$.expr[':'].uri = uriSizzle;

I believe this should be changed to:

$.expr.pseudos.uri = uriSizzle;

Here's the explanation and recommended change: https://github.com/jquery/jquery-migrate/blob/master/warnings.md#jqmigrate-jqueryexpr-is-deprecated-use-jqueryexprpseudos

Didn't see anything regarding jQuery 3 support for URI.js, so I realize it may not be there yet, but thought I would at least submit this issue.

Airn5475 avatar Apr 25 '17 13:04 Airn5475

I'm open to PRs tackling this :)

rodneyrehm avatar Apr 25 '17 14:04 rodneyrehm

I would be willing to submit a PR, but I'm honestly not sure how to test this code, since I'm not sure what it's doing. I just know jQuery Migrate 3.0 was complaining about this line.

Also, from what I've seen, it's only backwards compatible to v1.8, not sure the best way to handle that.

Airn5475 avatar Apr 25 '17 14:04 Airn5475

Any news about this topic ?

danielmm0621 avatar Sep 04 '18 16:09 danielmm0621