mediaelement icon indicating copy to clipboard operation
mediaelement copied to clipboard

Firefox issue with cancelFullscreen

Open swashbuck opened this issue 5 months ago • 0 comments

When exiting a fullscreen video with the ESC key in Firefox, an error is thrown:

Uncaught (in promise) TypeError: Not in fullscreen mode
    cancelFullScreen file:///mediaelement/build/mediaelement-and-player.js:6875
    exitFullScreen file:///mediaelement/build/mediaelement-and-player.js:1505
    fullscreenChanged file:///mediaelement/build/mediaelement-and-player.js:1372

I would suggest checking if the browser in fullscreen mode first using isFullScreen():

exports.cancelFullScreen = cancelFullScreen = function cancelFullScreen() {
	if (!isFullScreen()) return;
	if (hasWebkitNativeFullScreen) {
		_document2.default.webkitCancelFullScreen();
	} else if (hasMozNativeFullScreen) {
		_document2.default.mozCancelFullScreen();
	} else if (hasMsNativeFullScreen) {
		_document2.default.msExitFullscreen();
	}
};

swashbuck avatar Sep 03 '24 17:09 swashbuck