mediaelement-plugins icon indicating copy to clipboard operation
mediaelement-plugins copied to clipboard

Published 20 hours ago • verified publisher icon mediaelement

Update chromecast.html

Open mircobabini opened this issue 4 years ago • 7 comments

Doesn't work otherwise, the onload wrapper directive is needed.

mircobabini avatar May 02 '20 17:05 mircobabini

Yeah, fuck my editor. Just wanted to add the wrapping line:

window.onload = function() {

mircobabini avatar May 03 '20 09:05 mircobabini

I tried to modify you PR, but hit a "refusing to merge unrelated histories" from git.. So it's on your side to rework the PR

karawitan avatar May 03 '20 10:05 karawitan

It seems I don't have so much skills here, can't revert it :/ I think it's easier if you just refuse my pull request and made the edit by yourself :)

mircobabini avatar May 03 '20 14:05 mircobabini

oki let's do that

karawitan avatar May 03 '20 18:05 karawitan

Ha ! I found the best way I think. Please try this to build a new PR: go to https://github.com/mediaelement/mediaelement-plugins/blob/master/demo/chromecast.html Click on "Edit this file" Modify as needed Follow the instructions to create the new PR :) This way credits will go to you like they should :)

karawitan avatar May 03 '20 18:05 karawitan

Hi guys, can you please check this https://github.com/mediaelement/mediaelement-plugins/issues/172 , thanks, am sorry for the disturbance

throne1986 avatar May 07 '20 21:05 throne1986

@berryamin here you go #173

mircobabini avatar May 13 '20 07:05 mircobabini