[Android] Video output broken with mpv 0.37 or higher

[Predidit]

Currently, on the Android platform, we use libmpv.so binary from https://github.com/media-kit/libmpv-android-audio-build. We are using version 1.1.5 (based on mpv 0.36).

However, if we switch to the 1.1.6 release from the same repository, the video starts flickering constantly. I tried manually compiling other versions of libmpv, and any version later than mpv 0.37 triggers the same issue. Since mpv 0.36 is outdated, it might be better to fix this issue or at least remove the broken 1.1.6 release from https://github.com/media-kit/libmpv-android-audio-build.

[Predidit]

@alexmercerind

Sorry to bother you, but I was wondering why video-out-params is used instead of video-params when retrieving video-related parameters from FFI at

https://github.com/Predidit/media-kit/blob/d8eb365f7e957020f68309214e142fc527b855c7/media_kit/lib/src/player/native/player/real.dart#L1933-L1949

I noticed that switching to video-params could easily fix the issue, but I'm concerned it might break something else.

[alexmercerind]

Hi!

I'm not sure what could be causing it. Feel free to submit a pull-request. With that being said, other platforms still use video-out-params, e.g.

https://github.com/media-kit/media-kit/blob/50cdb26aed2c7a56f6714277e4be471138123fb8/media_kit_video/windows/video_output.cc#L425

Thanks!

[Predidit]

@alexmercerind

I have submitted a PR, but I wasn't able to assign you as a reviewer. The structure of the media kit is extremely complex, and my understanding of it is limited. Please let me know if I've messed anything up.