rainbow_csv icon indicating copy to clipboard operation
rainbow_csv copied to clipboard

Don't modify laststatus

Open igorlfs opened this issue 1 year ago • 2 comments

Hello,

for some reason, the plugin sets laststatus to 2 every time a csv buffer is focused. Why is it like that? Could we have an option to disable that?

igorlfs avatar Oct 15 '23 16:10 igorlfs

Hey, thanks for reporting! Sorry for the late response, the plugin indeed sets set laststatus=2, I will look into this and try to find a workaround.

mechatroner avatar Nov 26 '23 13:11 mechatroner

Oh, shoot!

I closed this issue because I just noticed I actually wanted to report it in the other rainbow csv plugin (which I just did). If you wanna look into that here, that's cool too :)

igorlfs avatar Nov 26 '23 13:11 igorlfs

Just checking, is the set laststatus=2 done to support the Select and Update status line features? Because if so, one option is to have that feature be disableable altogether.

Also maybe of note: I checked and those status line features do seem to work fine with set laststatus=3 (which I'd imagine is the main alternative setting to 2, especially for Neovim users), although the status line can definitely be a little far from the window with the CSV buffer if there's a bunch of splits. So if the goal in setting laststatus was to make sure the status line is visible in the case of 0 or 1, then laststatus could just be set if its value is not currently 3 (since it's already visible for 3).

brdoney avatar Apr 23 '24 04:04 brdoney

Thanks, @brdoney , you are right - laststatus modification is not needed for the core functionality. I removed it as well as number adjustment. The plugin should respect user configuration. Fixed.

mechatroner avatar Apr 24 '24 01:04 mechatroner