HES_EXECUTOR_NEVER_SHUTDOWN false positive

[boris-petrov]

When a custom ThreadFactory is passed which sets the threads as daemon ones, this warning is falsy because daemon threads do not stop the JVM from exiting. Not sure how complex this is to fix though.

[mebigfatguy]

looking at the code, it tries to set the priority to LOW if it sees a ThreadFactory being passed. Is this happening, at least?

[boris-petrov]

@mebigfatguy - yes, it marks it as low priority.

Another interesting thing is that when using Executors.newSingleThreadScheduledExecutor - this HES_EXECUTOR_NEVER_SHUTDOWN warning does not get triggered. It does only when doing new ThreadPoolExecutor. I guess this is a false negative.