Dan Buch

Results 167 comments of Dan Buch

@jtagcat I'm happy to start publishing releases in the `v3` series, fwiw, with the stipulation that versions would have a `beta` suffix or whatever is necessary to ensure clarity about...

@ipostelnik Sorry for the long delay! 😭 Any chance you're interested in refreshing this work, especially in light of [the most recent round of flag generation tooling](https://github.com/urfave/cli/pull/1382)?

@dearchap if you're interested in seeing this work moved forward, I think I would prefer the use of the more recently-(re)introduced `internal/genflags`. WDYT?

@icholy you may want to consider using the recently-added (by @toaster 🙇🏼) ability to [get the value directly from a given flag](https://github.com/urfave/cli/pull/1367#issuecomment-1133478036)

@dearchap Are you up for addressing the conflicts and getting the test coverage above the threshold? No worries if not. I'm happy to take this work to completion.

@dearchap looks like tests are happy now -- coverage thresholds are still grumpy, but I don't want to be draconian about those checks. Maybe add some coverage threshold wiggle room...

@icholy yes! Sorry for not being clear about that distinction. What you propose LGTM 🤘🏼

> I'm also wondering whether handling this event via a hook would be more powerful. Oooh I like that idea a lot @julian7

@dbarrosop Thank you for reporting this! Are you seeing this behavior with the latest `1.22.x` release? I have no reason to believe that the bug has been fixed, but I'd...

@dearchap hey sorry, on it now!