min-vid icon indicating copy to clipboard operation
min-vid copied to clipboard

Published 20 hours ago • verified publisher icon meandavejustice

Support hiding overlay icon for fullscreen views on new youtube ui

Open meandavejustice opened this issue 7 years ago • 5 comments

https://github.com/meandavejustice/min-vid/commit/f9f512be85f18b1638cb268b5c5f15308afee40f#commitcomment-24275031

meandavejustice avatar Sep 13 '17 16:09 meandavejustice

Tested this with today's custom repo build and here are the results:

  1. The issue is still reproducible using the new Youtube UI, on all Firefox versions. However we've noticed that if we install Min Vin on an older Nightly build, access Youtube, and then update the browser to latest Nightly build, the issue is no longer reproducible until the tab is closed or the UI is changed to the old Youtube and then back to new.

  2. On the other hand, using the old Youtube UI, the Min Vid overlay seems to be hidden only on latest Nightly 58.0a1 (2017-09-21); on Beta and Release versions, the Min Vid button is still displayed when going on Fullscreen.

@meandavejustice, should we reopen bug [#964] for the second issue regarding Youtube's old UI?

Softvision-MariusComan avatar Sep 22 '17 15:09 Softvision-MariusComan

I tested this issue using latest Min Vid v.0.4.4 (built on 9/25/2017) and I can confirm that this is fixed on the old YouTube UI, using all Firefox versions, on Win 10 x64, Mac 10.12 and Ubuntu 14.04 x 64. However, this issue is still reproducible when using the new YouTube UI, on all Firefox versions on the platforms mentioned before. You can see the screen recording of this issue here: https://goo.gl/zA9eRo.

Softvision-CristinaBadescu avatar Sep 25 '17 11:09 Softvision-CristinaBadescu

@meandavejustice I've looked a bit deeper since it's a recurring issue and found 2 cases.

  1. Refreshing the video page makes the overlay icon to disappear in full screen. It seems that the overlay is only displayed the first time. If you refresh the video page and go full screen again, the video no longer shows the overlay icons.
  2. Any video opened in a new tab trough context menu or middle click, does not show this behavior.

So it seems to be something related to how you navigate to the video page.

SoftVision-PaulOiegas avatar Sep 25 '17 12:09 SoftVision-PaulOiegas

@SoftVision-PaulOiegas I can confirm #1 as a working bandaid. Thanks for documenting.

escalonn avatar Nov 16 '17 03:11 escalonn

Copied my comment from another issue about an edge case in the current fullscreen detection:

I would like to mention that a lot of times I go into fullscreen faster than the overlay loads, and MinVid does not detect fullscreen correctly when it loads, so it places the overlay into fullscreen anyway. Exiting fullscreen and re-entering it fixes the issue, but it'd still be nice to fix this edge case.

chylex avatar Dec 13 '17 12:12 chylex