magedbm icon indicating copy to clipboard operation
magedbm copied to clipboard

Fail during `backupMove()` doesn't throw exception

Open adam-paterson opened this issue 8 years ago • 2 comments

rename() can fail fail on line GetCommand.php:229 and there is no error handling for this method.

screen_shot_2018-02-26_at_13_05_35

adam-paterson avatar Feb 26 '18 13:02 adam-paterson

Need to check that the destination is writable before anything starts too.

punkstar avatar Feb 26 '18 13:02 punkstar

It currently checks the directory is writable but we should update that check to be specifically checking the file path is writable and that we catch the error 👍

bobbyshaw avatar Feb 26 '18 13:02 bobbyshaw