meanbee
Use the run mode in the CLI image
At the moment we set the run mode for Magento in the Nginx configuration, but we don't do anything on the CLI image. This means that we could have Magento running in one mode and the CLI magento command running in another, something that might cause issues.
I think we should remove the run mode environment variable altogether and let Magento decide which mode to run in. Having the run mode in the web server config as well as configured in Magento's app/etc/env.php is confusing and also means that bin/magento deploy:mode:set does not have the intended effect.
+1 On Fri, 1 Dec 2017 at 11:10, Tomas Gerulaitis [email protected] wrote:
I think we should remove the run mode environment variable altogether and let Magento decide which mode to run in. Having the run mode in the web server config as well as configured in Magento's app/etc/env.php is confusing and also means that bin/magento deploy:mode:set does not have the intended effect.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meanbee/docker-magento2/issues/61#issuecomment-348468441, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK7gI89XpLfS9zpQfw66T4C_UvcgW1Aks5s796OgaJpZM4MHYG4 .