Abin Simon

Results 250 comments of Abin Simon

I think in that case the quickest option would be to just use the option suggested by https://github.com/Peltoche/lsd/issues/712#issuecomment-1232868513 .

@zwpaper I don't think we should collect errors into a `vec` and print them in main. From what I can see, gnu ls just seems to print the errors as...

I think in `lsd` we are printing the errors as we go while printing the actual output only at the end. But if we were to collect the errors and...

@zwpaper Yeah, that does make sense. Since we will not be sorting across multiple directories, I don't think we have buffer all the output, but rather just per folder. But...

Closing in favor of https://github.com/Peltoche/lsd/pull/739 . Thanks for starting the work on this PR :D

Makes sense, lets go with a `--color-theme` flag. About auto detection, I am not sure if we will have a simple way to do dark mode/light mode detection in terminals...

We have most of these now ;) Anyone landing here, feel free to open and issue for any specific sort method.

That is a neat language addition. I was not aware of it. Could you bump up the min version in build script as well. https://github.com/Peltoche/lsd/blob/1553aafe9db589dfe9d0385a2111127060af8db8/build.rs#L21

If `1.62.0` would do, lets keep it as that.

> Could you clarify to me why it's better to use 1.62.0? The min version we support is not as important as it is not a lib but I would...