Collected other pull request and Fixbug memory leaks and weakness argument pointer for tcp/ip callback function

[TienHuyIoT]

Fixbug memory leaks

• AysncClient recv callback handle missing call pbuf_free()

Fix crash tcp/ip api calls

• Due to tcp_api_call_t msg declared local variant and used to as a pointer argument for the callback function. So this does not make sure that the memory holding the parameters of the pointer variant is handled right.

[mathieucarbou]

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

[TienHuyIoT]

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

Thanks, You can reference my pull request. It has some fix-bug relevant to memory leaks and handling weakness tcp/ip callback function. I checked your repository. It still has these bug in your repo.

[mathieucarbou]

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

Thanks, You can reference my pull request. It has some fix-bug relevant to memory leaks and handling weakness tcp/ip callback function. I checked your repository. It still has these bug in your repo.

This is not my repo ;-) I am just watching and saw your PR, that's it.

If you leave it there, it will be lost. Nobody will act on it. If you send it against a repo maintained by an organisation like ESPHome, more likely somebody will look at it and merge it.

But I have no relationship with any of these projects ;-) Like said, I was just noticed about your PR through email and I think it has a lot of value so I took time to comment and advise you to instead send it against a maintained repo, not a dead one ;-)

[TienHuyIoT]

This project seems quite dead since 4y... I would rather send PRs against this one now: https://github.com/esphome/AsyncTCP which is maintained by ESPHome (https://esphome.io)

Thanks, You can reference my pull request. It has some fix-bug relevant to memory leaks and handling weakness tcp/ip callback function. I checked your repository. It still has these bug in your repo.

This is not my repo ;-) I am just watching and saw your PR, that's it.

If you leave it there, it will be lost. Nobody will act on it. If you send it against a repo maintained by an organisation like ESPHome, more likely somebody will look at it and merge it.

But I have no relationship with any of these projects ;-) Like said, I was just noticed about your PR through email and I think it has a lot of value so I took time to comment and advise you to instead send it against a maintained repo, not a dead one ;-)

I got it, Thank you!

[mathieucarbou]

I've grabbed most of the fixes in my fork: https://github.com/mathieucarbou/AsyncTCP/pull/10

Still, please see my comment. A change in one condition looks really weird to me.