Rohit Dandamudi

Results 44 comments of Rohit Dandamudi

Captured the LLM model and prompt information and kv stores get and set key information Not sure if the key is accessible when querying on Prometheus/Grafana ![Screenshot from 2024-08-21 11-50-55](https://github.com/user-attachments/assets/8af41177-eb60-4470-9d3b-7cf7abbcc7ad)...

I changed the base to factors, and it should only reflect my code changes. Thanks for checking in @itowlson !

@calebschoepp I am not sure how to test the telemetry metrics in factors. For llm-compute, I think I am capturing it in the right place. However, when I run the...

> You might need to enable the `serde` feature for the `url` crate. https://docs.rs/url/latest/url/#feature-serde That did the trick, tests passed :D I am just curious how the tests passed before,...

> Are you still having errors running it @me-diru? I would need to see the runtime config you're using to help more. Yes, it's still happening. When I run the...

@calebschoepp I think it's now capturing the metrics in the new factors code! ![image](https://github.com/user-attachments/assets/78b104a3-b485-423e-bfef-d13d4d62df14)

@calebschoepp Yes! Please review :D

The plan was to merge it to `factors` branch capturing metrics in the new codebase. @calebschoepp I wonder if the `main` branch was updated to point the PR there? 👀...

I have excluded capturing key details in the metrics. However, I was still getting some weird linting issues. It would be great to get more context on them!

> Seems like there aren't any linting errors in CI. Are you just experiencing those linting errors locally? What are they? I think so. This is what I got. ![Screenshot...