eslint-mdx icon indicating copy to clipboard operation
eslint-mdx copied to clipboard

meta: how can we support `eslint-define-config` better?

Open JounQin opened this issue 1 year ago • 6 comments
trafficstars

Initial checklist

Problem

mdx support was added at https://github.com/eslint-types/eslint-define-config/pull/124, but somehow it's removed later?

I hope the end users can use eslint-plugin-mdx with typings support easily.

cc @Shinigami92

Solution

I'm not quite familiar with eslint-define-config, so I'd prefer to listening from experienced @Shinigami92

Alternatives

N/A

JounQin avatar Jan 22 '24 03:01 JounQin

There needs to be a file that can be imported via ref like /// <reference types="eslint-plugin-mdx/define-config-support" />

In that file it should look like e.g. https://github.com/eslint-types/define-config-plugin-types/blob/main/types/import/index.d.ts

Shinigami92 avatar Jan 22 '24 10:01 Shinigami92

Can that be supported from eslint-plugin-mdx's side natively?

JounQin avatar Jan 22 '24 10:01 JounQin

Can that be supported from eslint-plugin-mdx's side natively?

YES, thats why these global augmentations are there.

Shinigami92 avatar Jan 22 '24 10:01 Shinigami92

Would you to raise a PR here? I'd to get some experiences here and then use it on eslint-pligin-i later. ❤️

JounQin avatar Jan 22 '24 11:01 JounQin

Would you to raise a PR here? I'd to get some experiences here and then use it on eslint-pligin-i later. ❤️

Yeah, I can try 👍 Not sure when, but I will try to set it on my list for this week

Shinigami92 avatar Jan 22 '24 11:01 Shinigami92

It's not in emergency.

JounQin avatar Jan 22 '24 13:01 JounQin