editor icon indicating copy to clipboard operation
editor copied to clipboard

The Link Dialog doesn't work on mobile

Open hahhen opened this issue 1 year ago • 8 comments

Steps to reproduce:

On a mobile device: Open the demo Click the link button

When nothing is selected, it just doesn't do anything When something is selected, it opens and closes very fast

hahhen avatar Jan 21 '24 15:01 hahhen

By mobile do you mean iOS or Android?

petyosi avatar Jan 21 '24 16:01 petyosi

My phone is an Android device, I haven't tested it on iOS.

hahhen avatar Jan 21 '24 16:01 hahhen

I see. Might take me some time to set up a convenient testing environment. If you're feeling like it, I'm happy to accept a contribution.

petyosi avatar Jan 21 '24 17:01 petyosi

I'll try to see what I can do, but I'm pretty much a newbie on React development (and I'm not used to Radix either)

hahhen avatar Jan 21 '24 17:01 hahhen

I asked my friend to test on his iPhone. He said it doesn't work either

hahhen avatar Jan 22 '24 01:01 hahhen

I tested it on a mobile device, and it seems like the popup opening and the form size does not work well for mobile (even leaving the form closing aside). If you're going to develop an UI that needs to work on mobile, I think the best option is to build a UI that's specific for the small screen - even a small browser prompt would work I guess.

petyosi avatar Jan 23 '24 07:01 petyosi

@hahhen If you're still interested in doing this, it was easy enough to use the LinkDialog option in the linkDialogPlugin. I started with the default implementation in the repo (changing the imports to @mdxeditor/editor) and modified it to be mobile-friendly.

braincore avatar May 03 '24 06:05 braincore

I confirm this is still not fixed, and does not work on mobile, using android or iOS. Easy to test, as it does not work on the main demo editor here mdxeditor.dev

@braincore do you have a code example that would illustrate how you managed to customize the LinkDialog?

gregStevenard avatar Sep 03 '24 17:09 gregStevenard