use-metamask icon indicating copy to clipboard operation
use-metamask copied to clipboard

fix for issue #18

Open matthewkeil opened this issue 3 years ago • 2 comments

matthewkeil avatar Nov 11 '21 06:11 matthewkeil

Heya! Thank you for your contribution! May I ask you to remove package-lock.json and dist package from the PR?

mdtanrikulu avatar Dec 09 '21 17:12 mdtanrikulu

Hey! Wondering what happened to this PR, as it seems the fix is ready. Seems a shame it still can't be used with NextJS without the workaround.

GAlcaraz avatar Jul 18 '22 00:07 GAlcaraz

Codecov Report

Merging #19 (36ae6c0) into main (1ef09b4) will decrease coverage by 1.28%. The diff coverage is 50.00%.

@@             Coverage Diff             @@
##              main      #19      +/-   ##
===========================================
- Coverage   100.00%   98.71%   -1.29%     
===========================================
  Files            2        2              
  Lines           76       78       +2     
  Branches        21       22       +1     
===========================================
+ Hits            76       77       +1     
- Misses           0        1       +1     
Flag Coverage Δ
unittests 98.71% <50.00%> (-1.29%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/useMetamask.js 98.46% <50.00%> (-1.54%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Dec 03 '22 15:12 codecov-commenter

I was away from maintaining the package for some time, was waiting some changes from the pr owner as well, but applying it now.

mdtanrikulu avatar Dec 03 '22 15:12 mdtanrikulu