Update to record timestamp and duration authoratively

[codefromthecrypt]

Recent versions of zipkin have a duration query that only works when timestamp and duration are set authoritatively. This implies adding the fields to the Span type when reporting to zipkin. These should be set when originating a new span (ex. all root and client spans, but not set on spans continued via B3 headers).

This was noticed by @prbarl who found duration query not working in cassandra for this reason

See https://github.com/openzipkin/openzipkin.github.io/issues/49 for more details.

[jcarres-mdsol]

You mean that instrumentation needs to set duration or duration on the UI would not be displayed?

[codefromthecrypt]

It is about querying by duration in the UI. Ex traces longer than 10s

On 18 Apr 2017 5:45 pm, "Jordi Polo Carres" [email protected] wrote:

You mean that instrumentation needs to set duration or duration on the UI would not be displayed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mdsol/Medidata.ZipkinTracerModule/issues/107#issuecomment-294752173, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD615nCDP9q6ZAXCNilfEbX9Xtu3jaOks5rxIZJgaJpZM4MmECf .

[jcarres-mdsol]

Cool, understood, thanks