shotshare icon indicating copy to clipboard operation
shotshare copied to clipboard

Image preview embed for Discord et. al.

Open EmberHeartshine opened this issue 1 year ago • 5 comments
trafficstars

Title. Many image hosts have an embed that serves the image if it's linked on a service that's capable of displaying URL previews like Discord, Twitter, etc). I don't know what would go into this from a technical standpoint but it would be nice to have.

EmberHeartshine avatar Feb 12 '24 21:02 EmberHeartshine

Spent a fair bit of time testing on this, no matter what meta tags I tried, I was not able to get Discord displaying these images from the shot view, will revisit this soon though and see if I can figure it out.

mdshack avatar Apr 15 '24 00:04 mdshack

Even <meta property="og:image" content="[image link]"> ?

EmberHeartshine avatar Apr 15 '24 01:04 EmberHeartshine

Indeed @EmberHeartshine, here's some of the tags I tried.

mdshack avatar Apr 18 '24 00:04 mdshack

I'm not familiar with vue formatting, is the colon before content removed when processing for the client?

EmberHeartshine avatar Apr 18 '24 00:04 EmberHeartshine

I'm not familiar with vue formatting, is the colon before content removed when processing for the client?

Correct, : indicates an expression as opposed to a static value

mdshack avatar Apr 19 '24 00:04 mdshack

The reason that the changes above don't work is that they rely on javascript injecting the tags. Most metdata scrapers don't render pages, they just fetch the base HTML and look for tags.

This PR should do what's needed: https://github.com/mdshack/shotshare/pull/62

bentasker avatar Jul 14 '24 09:07 bentasker

The reason that the changes above don't work is that they rely on javascript injecting the tags. Most metdata scrapers don't render pages, they just fetch the base HTML and look for tags.

This PR should do what's needed: #62

Good catch and thank you for opening a PR!

mdshack avatar Jul 26 '24 14:07 mdshack