evm-diff icon indicating copy to clipboard operation
evm-diff copied to clipboard

add routescan explorers

Open IperGiove opened this issue 1 year ago • 4 comments

This PR is promoted by Routescan with the aim of improving the quality of the data as much as possible in an open-source manner.

The PR just adds the links to Routescan's explorer in the json chains data.

IperGiove avatar Jul 03 '24 21:07 IperGiove

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evm-diff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 9:46pm

vercel[bot] avatar Jul 03 '24 21:07 vercel[bot]

The modified files are autogenerated, so this will be overwritten the next time data is updated.

Instead, we’ll want to modify script/data/input.json to add these additional explorers as inputs, and modify the getMetadata method to include them in the output data

mds1 avatar Jul 04 '24 12:07 mds1

The modified files are autogenerated, so this will be overwritten the next time data is updated.

Instead, we’ll want to modify script/data/input.json to add these additional explorers as inputs, and modify the getMetadata method to include them in the output data

I know you are using this repo for the api here`:

async function getMetadata(chainId: number): Promise<Metadata> {
	const response = await fetch('https://chainid.network/chains.json');
	const data = await response.json();
	const metadata = data.find((chain: Metadata) => chain.chainId === chainId);
	if (!metadata) throw new Error(`Chain with ID ${chainId} not found.`);
	return metadata;
}

And that repo gets the data from this one. For that reason yesterday I made a PR to update the data here: https://github.com/ethereum-lists/chains/pull/5428.

However, do you mean you want to transform the script/data/feature/metadata.json into something like script/data/input.json? is that correct?

IperGiove avatar Jul 04 '24 14:07 IperGiove

Ah that’s perfect, adding it upstream is preferable. Let’s give the https://github.com/ethereum-lists/chains repo some time to merge that, in which case we can close this and have it included automatically

mds1 avatar Jul 04 '24 16:07 mds1

Closed by https://github.com/mds1/evm-diff/pull/95

mds1 avatar Dec 04 '24 00:12 mds1