Maurizio Drocco
Maurizio Drocco
It seems disappeared with #72.
Here is a new one, following up #1180. The type checker reports a possibly unbounded variable in the verifier's code. https://github.com/keylime/keylime/blob/8e417f5b99f0dea0f9f36e26ab15549fcd3e1844/keylime/cloud_verifier_tornado.py#L608 I tried the obvious fix but it breaks CI...
Update: PR #1186 fixes the reported problems in `ima/ima_dm.py`, I am removing the section of the issue about that file.
Update: PR #1194 fixes the reported problems in `ima/file_signatures.py` and `json.py`, I am removing the section of the issue about those files.
I am restructuring this issue to keep track of all the files with outstanding type issues, considering the existing PRs.
update: upgrading Lark from 1.1.3 to 1.1.4 fixed the issue below: ```console /home2/mdrocco/git/keylime/keylime/ima/ima_dm.py /home2/mdrocco/git/keylime/keylime/ima/ima_dm.py:16:18 - error: "Lark" is not exported from module "lark" Import from "lark.lark" instead (reportPrivateImportUsage) /home2/mdrocco/git/keylime/keylime/ima/ima_dm.py:16:24 -...
update: PR #1268 (and #1308) fixed the verifier. How much do we care about the outstanding issues? @aplanas @THS-on @stefanberger
Thanks, I will look at `elchecking` next. @aplanas, everything ima is type-fixed as far as I can tell.